look ahead same patterns as its own when concatenation#78
Merged
namusyaka merged 1 commit intosinatra:masterfrom Jan 1, 2018
Merged
Conversation
Member
Author
|
@rkh I'd like you to carefully review this change. |
The meaning of the following two expressions is different, but it's unexpected behavior.
Mustermann.new("/a") + Mustermann.new("/b") + Mustermann.new(/c/)
Mustermann.new("/a") + (Mustermann.new("/b") + Mustermann.new(/c/))
The differencet leads to occur a bug on sinatra-namespace.
This commit fixes sinatra/sinatra#1361
7ae678b to
887fa38
Compare
Member
Author
|
I've force-pushed to simplify the code. |
rkh
approved these changes
Dec 13, 2017
Member
rkh
left a comment
There was a problem hiding this comment.
Looks good, sorry for the late reply.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The meaning of the following two expressions is different, but it's unexpected behavior.
The differencet leads to occur a bug on sinatra-namespace.
This commit fixes sinatra/sinatra#1361