Fix performance issue for Mustermann::AST::Translator#escape#142
Merged
dentarg merged 1 commit intosinatra:mainfrom Sep 3, 2024
Merged
Fix performance issue for Mustermann::AST::Translator#escape#142dentarg merged 1 commit intosinatra:mainfrom
dentarg merged 1 commit intosinatra:mainfrom
Conversation
Member
Contributor
|
This seems okay to me. I don't want to spend my time for keeping 100% coverage. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Trying to get 100% coverage for #140
Close #140