bring the Logger deprecated method forward from 2.3#2225
Merged
monkeyiq merged 1 commit intosimplesamlphp:masterfrom Aug 30, 2024
Merged
bring the Logger deprecated method forward from 2.3#2225monkeyiq merged 1 commit intosimplesamlphp:masterfrom
monkeyiq merged 1 commit intosimplesamlphp:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I added the Logger deprecated method in #2223 to allow a clear statement that a logging message is about deprecated functionality that will be removed.
The use in 2223 is not needed in master as the functionality was removed from there. The
deprecatedmethod is brought forward without a caller so it is not "missing" from master and doesn't cause an issue in the future if some code calling it is cherry picked.