Bugfix: Continue unencrypted if no encryption key is available#2204
Closed
Bugfix: Continue unencrypted if no encryption key is available#2204
Conversation
Member
|
I'm not such a fan of silent fallthrough to unencrypted. If the user explicitly set encryption on in the config, it would violate the principle of least surprise that attribute values are revealed if metadata is missing a required cert. I think the fail safe approach is that if encryption is explicitly requested but not possible, to give a clear error and not not encrypt things the user wanted encrypted. The suggested optionalEncryption approach in the linked mail thread sounds like a much safer approach and keeps the ability for admins to indicate whether they always want their data to be encrypted, or if they just want opportunistic encryption. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See: https://groups.google.com/g/simplesamlphp/c/PVX0f99OJqg
We can set
assertion.encryptedall we want on our IdP-side, but if the SP doesn't provide a key it's useless. Instead of failing the hard way, see if the SP is willing to accept an unencrypted assertion.Alternative: add another configuration flag that enforces the use of encryption. This could be a more generic flag to enforce SAML2INT compliance.