i18n: set the domain for a theme if it is missing (#2392)

monkeyiq · monkeyiq · commit fbbe1397e60c · 2025-02-20T15:49:28.000+10:00
* i18n: set the domain for a theme if it is missing

If there is no header in the po file then it was not being found for a
theme. This PR allows po files to exist without any header such as the below.

msgid ""
msgstr ""
"X-Domain: worldpeace\n"

* lint

* changelog
diff --git a/docs/simplesamlphp-changelog.md b/docs/simplesamlphp-changelog.md
@@ -9,6 +9,16 @@ See the [upgrade notes](https://simplesamlphp.org/docs/stable/simplesamlphp-upgr
 
 Released TBD
 
+## Version 2.3.7
+
+Released TBD
+
+* Fixed loading translations for themes where there is no explicit X-Domain set in the po file.
+
+## Version 2.3.6
+
+Released 2025-02-17
+
 * Fixed PHP 8.4 deprecation notices
 * Fixed infinite recursion (#2367)
 * Added a new feature flag `encryption.optional` to allow unencrypted assertions if the SP does
diff --git a/src/SimpleSAML/Locale/Localization.php b/src/SimpleSAML/Locale/Localization.php
@@ -265,6 +265,9 @@ private function loadGettextGettextFromPO(
             $file = new File($langPath . $domain . '.po', false);
             if ($file->getRealPath() !== false && $file->isReadable()) {
                 $translations = (new PoLoader())->loadFile($file->getRealPath());
+                if (empty($translations->getDomain())) {
+                    $translations->setDomain($domain);
+                }
                 $arrayGenerator = new ArrayGenerator();
                 $this->translator->addTranslations(
                     $arrayGenerator->generateArray($translations),
