Revert constructor property promotion; values appear to be readonly unless passed by reference

tvdijen · tvdijen · commit d4569133c028 · 2023-11-27T22:51:58.000+01:00
diff --git a/src/SimpleSAML/Metadata/SAMLParser.php b/src/SimpleSAML/Metadata/SAMLParser.php
@@ -141,6 +141,13 @@ class SAMLParser
      */
     private array $registrationInfo;
 
+    /**
+     * This is an array of elements that may be used to validate this element.
+     *
+     * @var \SimpleSAML\SAML2\SignedElementHelper[]
+     */
+    private array $validators = [];
+
     /**
      * @var \Symfony\Component\Filesystem\Filesystem
      */
@@ -159,7 +166,7 @@ class SAMLParser
     private function __construct(
         EntityDescriptor $entityElement,
         ?int $maxExpireTime,
-        private array $validators = [],
+        array $validators = [],
         array $parentExtensions = []
     ) {
         $this->fileSystem = new Filesystem();
@@ -168,7 +175,8 @@ private function __construct(
 
         $expireTime = self::getExpireTime($entityElement, $maxExpireTime);
 
-        $validators[] = $entityElement;
+        $this->validators = $validators;
+        $this->validators[] = $entityElement;
 
         // process Extensions element, if it exists
         $ext = self::processExtensions($entityElement, $parentExtensions);
