Replace direct use of global variable

tvdijen · tvdijen · commit ccc6e6218847 · 2025-10-10T22:44:01.000+02:00
diff --git a/modules/saml/src/IdP/SAML2.php b/modules/saml/src/IdP/SAML2.php
@@ -397,8 +397,8 @@ public static function receiveAuthnRequest(IdP $idp): void
                 );
             }
 
-            if (isset($_REQUEST['username'])) {
-                $username = (string) $_REQUEST['username'];
+            if ($request->query->has('username')) {
+                $username = $request->query->get('username');
             }
 
             $issuer = $request->getIssuer();

Original file line number	Diff line number	Diff line change
`@@ -397,8 +397,8 @@ public static function receiveAuthnRequest(IdP $idp): void`
`397`	`397`	`);`
`398`	`398`	`}`
`399`	`399`
`400`		`- if (isset($_REQUEST['username'])) {`
`401`		`- $username = (string) $_REQUEST['username'];`
	`400`	`+ if ($request->query->has('username')) {`
	`401`	`+ $username = $request->query->get('username');`
`402`	`402`	`}`
`403`	`403`
`404`	`404`	`$issuer = $request->getIssuer();`