Fix unit tests for PHP 8.3

tvdijen · tvdijen · commit ff512eacb314 · 2023-12-18T14:24:21.000+01:00
diff --git a/tests/SAML2/XML/mdrpi/PublicationInfoTest.php b/tests/SAML2/XML/mdrpi/PublicationInfoTest.php
@@ -125,17 +125,17 @@ public function testMissingPublisherThrowsException(): void
      */
     public function testMultipleUsagePoliciesWithSameLanguageThrowsException(): void
     {
-        $document = clone self::$xmlRepresentation;
+        $document = clone self::$xmlRepresentation->documentElement;
 
         // Append another 'en' UsagePolicy to the document
         $x = new UsagePolicy('en', 'https://example.org');
-        $x->toXML($document->documentElement);
+        $x->toXML($document);
 
         $this->expectException(ProtocolViolationException::class);
         $this->expectExceptionMessage(
             'There MUST NOT be more than one <mdrpi:UsagePolicy>,'
             . ' within a given <mdrpi:PublicationInfo>, for a given language'
         );
-        PublicationInfo::fromXML($document->documentElement);
+        PublicationInfo::fromXML($document);
     }
 }
diff --git a/tests/SAML2/XML/mdrpi/RegistrationInfoTest.php b/tests/SAML2/XML/mdrpi/RegistrationInfoTest.php
@@ -125,17 +125,17 @@ public function testRegistrationInstantTimezoneNotZuluThrowsException(): void
      */
     public function testMultipleRegistrationPoliciesWithSameLanguageThrowsException(): void
     {
-        $document = clone self::$xmlRepresentation;
+        $document = clone self::$xmlRepresentation->documentElement;
 
         // Append another 'en' RegistrationPolicy to the document
         $x = new RegistrationPolicy('en', 'https://example.org');
-        $x->toXML($document->documentElement);
+        $x->toXML($document);
 
         $this->expectException(ProtocolViolationException::class);
         $this->expectExceptionMessage(
             'There MUST NOT be more than one <mdrpi:RegistrationPolicy>,'
             . ' within a given <mdrpi:RegistrationInfo>, for a given language'
         );
-        RegistrationInfo::fromXML($document->documentElement);
+        RegistrationInfo::fromXML($document);
     }
 }

Original file line number	Diff line number	Diff line change
`@@ -125,17 +125,17 @@ public function testMissingPublisherThrowsException(): void`
`125`	`125`	`*/`
`126`	`126`	`public function testMultipleUsagePoliciesWithSameLanguageThrowsException(): void`
`127`	`127`	`{`
`128`		`- $document = clone self::$xmlRepresentation;`
	`128`	`+ $document = clone self::$xmlRepresentation->documentElement;`
`129`	`129`
`130`	`130`	`// Append another 'en' UsagePolicy to the document`
`131`	`131`	`$x = new UsagePolicy('en', 'https://example.org');`
`132`		`- $x->toXML($document->documentElement);`
	`132`	`+ $x->toXML($document);`
`133`	`133`
`134`	`134`	`$this->expectException(ProtocolViolationException::class);`
`135`	`135`	`$this->expectExceptionMessage(`
`136`	`136`	`'There MUST NOT be more than one <mdrpi:UsagePolicy>,'`
`137`	`137`	`. ' within a given <mdrpi:PublicationInfo>, for a given language'`
`138`	`138`	`);`
`139`		`- PublicationInfo::fromXML($document->documentElement);`
	`139`	`+ PublicationInfo::fromXML($document);`
`140`	`140`	`}`
`141`	`141`	`}`