Fix for getBooleanAttribute signature change

tvdijen · tvdijen · commit 9dc468f7a428 · 2023-02-08T23:08:54.000+01:00
diff --git a/src/SAML2/XML/shibmd/Scope.php b/src/SAML2/XML/shibmd/Scope.php
@@ -74,8 +74,7 @@ public static function fromXML(DOMElement $xml): static
         Assert::same($xml->namespaceURI, Scope::NS, InvalidDOMElementException::class);
 
         $scope = $xml->textContent;
-        /** @psalm-var bool $regexp */
-        $regexp = self::getBooleanAttribute($xml, 'regexp', 'false');
+        $regexp = self::getBooleanAttribute($xml, 'regexp', false);
 
         return new static($scope, $regexp);
     }

Original file line number	Diff line number	Diff line change
`@@ -74,8 +74,7 @@ public static function fromXML(DOMElement $xml): static`
`74`	`74`	`Assert::same($xml->namespaceURI, Scope::NS, InvalidDOMElementException::class);`
`75`	`75`
`76`	`76`	`$scope = $xml->textContent;`
`77`		`- /** @psalm-var bool $regexp */`
`78`		`- $regexp = self::getBooleanAttribute($xml, 'regexp', 'false');`
	`77`	`+ $regexp = self::getBooleanAttribute($xml, 'regexp', false);`
`79`	`78`
`80`	`79`	`return new static($scope, $regexp);`
`81`	`80`	`}`