Conversation
Alkarex
approved these changes
Jan 15, 2026
PHP 7.2 requires at least libcurl 7.10.5 so the check is always true on all supported PHP versions: https://github.com/php/php-src/blob/php-7.2.0/ext/curl/config.m4#L34 PHP 7.3 bumps the minimum to 7.15.5 but, even when we drop support for PHP < 7.4, that won’t help us with cleanups: https://github.com/php/php-src/blob/php-7.3.0/ext/curl/config.m4#L32 PHP 8.0 further bumps this to 7.29.0, which would allow us to remove the remaining conditionals, but we still support 7.2.0 for now and will support 7.4.0 for a while. https://github.com/php/php-src/blob/php-8.0.0/ext/curl/config.m4#L7
ad03066 to
df993b7
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PHP 7.2 requires at least libcurl 7.10.5 so the check is always true on all supported PHP versions:
https://github.com/php/php-src/blob/php-7.2.0/ext/curl/config.m4#L34
PHP 7.3 bumps the minimum to 7.15.5 but, even when we drop support for PHP < 7.4, that won’t help us with cleanups:
https://github.com/php/php-src/blob/php-7.3.0/ext/curl/config.m4#L32
PHP 8.0 further bumps this to 7.29.0, which would allow us to remove the remaining conditionals, but we still support 7.2.0 for now and will support 7.4.0 for a while.
https://github.com/php/php-src/blob/php-8.0.0/ext/curl/config.m4#L7