tests: Add type hints to data providers#813
Merged
mblaney merged 2 commits intosimplepie:masterfrom May 30, 2023
Merged
Conversation
There is no need for an unwieldy iteration with reference for a single item. We can yield the value instead of returning array. While at it, let’s also add type hints. Co-authored-by: Art4 <art4@wlabs.de>
4a5ce75 to
5c05210
Compare
and the tests that use them. This will be necessary for higher levels of PHPStan.
5c05210 to
64c32f7
Compare
Art4
approved these changes
May 22, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
First commit based on cherry-pick from #774, cc @Art4. Then continued adding type hints which will be necessary for higher levels of PHPStan.
Should be fine for rebase merge (no squash).