Use single constant for default HTTP Accept header#784
Merged
mblaney merged 3 commits intosimplepie:masterfrom Feb 13, 2023
Merged
Use single constant for default HTTP Accept header#784mblaney merged 3 commits intosimplepie:masterfrom
mblaney merged 3 commits intosimplepie:masterfrom
Conversation
And add missing headers in `SimplePie_Locator::body()` Follow-up of simplepie@5d966b9 This prepares for an update of the content of the default HTTP Accept header in another PR.
Alkarex
commented
Feb 8, 2023
| 'Accept' => File::DEFAULT_HTTP_ACCEPT, | ||
| ]; | ||
| $feed = $this->registry->create(File::class, [$value, $this->timeout, 5, null, $this->useragent, $this->force_fsockopen, $this->curl_options]); | ||
| $feed = $this->registry->create(File::class, [$value, $this->timeout, 5, $headers, $this->useragent, $this->force_fsockopen, $this->curl_options]); |
Contributor
Author
There was a problem hiding this comment.
Likely forgotten in 5d966b9
Otherwise, the $headers variable was not used.
Contributor
There was a problem hiding this comment.
👍
Looks like an error to me. I am in favor of fixing it this way.
Contributor
Author
|
Downstream PR FreshRSS/FreshRSS#5083 |
Alkarex
referenced
this pull request
Feb 8, 2023
Art4
requested changes
Feb 8, 2023
| 'Accept' => File::DEFAULT_HTTP_ACCEPT, | ||
| ]; | ||
| $feed = $this->registry->create(File::class, [$value, $this->timeout, 5, null, $this->useragent, $this->force_fsockopen, $this->curl_options]); | ||
| $feed = $this->registry->create(File::class, [$value, $this->timeout, 5, $headers, $this->useragent, $this->force_fsockopen, $this->curl_options]); |
Contributor
There was a problem hiding this comment.
👍
Looks like an error to me. I am in favor of fixing it this way.
jtojnar
reviewed
Feb 8, 2023
Co-authored-by: Jan Tojnar <jtojnar@gmail.com>
jtojnar
approved these changes
Feb 8, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The same string was repeated 5 times.
And add missing headers in
SimplePie_Locator::body()Follow-up of 5d966b9
This prepares for an update of the content of the default HTTP Accept header in another PR.