Add type hints in all classes#775
Merged
mblaney merged 7 commits intosimplepie:masterfrom Jan 31, 2023
Merged
Conversation
jtojnar
reviewed
Jan 24, 2023
Contributor
Author
|
Didn't know about this rule. I will try it. Thank you. 👍 |
Member
|
Would be nice to be able to use |
Contributor
Author
I've added them manually. We don't have much private methods. 🙂 |
jtojnar
reviewed
Jan 24, 2023
jtojnar
reviewed
Jan 24, 2023
jtojnar
reviewed
Jan 24, 2023
jtojnar
reviewed
Jan 24, 2023
jtojnar
reviewed
Jan 27, 2023
jtojnar
reviewed
Jan 27, 2023
jtojnar
reviewed
Jan 27, 2023
jtojnar
approved these changes
Jan 27, 2023
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds type hints to all methods in the
SimplePieclass where the arguments are documented. Thanks to type widening in PHP 7.2 this is not a breaking change.There are also many methods where the parameters are not documented. This places should be be documented, but for BC they should trigger a deprecation warning, if a parameter has to be casted. The type declaration could be added in SimplePie 2.0.0 with a breaking change.
This will fix #773.