Allow usage of PSR-16 cache implementation#742
Merged
mblaney merged 21 commits intosimplepie:masterfrom Oct 23, 2022
Merged
Conversation
jtojnar
reviewed
Oct 10, 2022
Member
jtojnar
left a comment
There was a problem hiding this comment.
I chewed through the code and it looks good overall. I annotated the parts that made me scratch my head for a bit.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi 👋
this PR allows the usage of an extern PSR-16 cache implementation by registering a new cache type in
Cacheclass.I propose this feature for SimplePie 1.8.0, see roadmap #731.
Next steps could be to deprecate the usage of the internal cache solutions (mysql, file, redis, memcache and memcached) and remove them in v2 in favor of PSR-16.