Upload compiled file as asset + tests#725
Merged
mblaney merged 6 commits intosimplepie:masterfrom Mar 31, 2022
Merged
Conversation
Contributor
Author
|
I've integrated the tests for the compiled file into the existing ci workflow. |
Contributor
Author
|
Any thoughts or questions? Is there anything I could improve? I would like to continue working on #722, but would need a decision if this PR is accepted. |
Member
|
looks good @Art4 thanks and sorry it took me a while to get to it |
Contributor
Author
|
You're welcome. No problem, I'm patient. 😊 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As I continued to work on #722, I noticed that there are no tests for the output of
build/compile.php. So I created a new workflow that runs all tests also with the code in the single file. This way we make sure that the single file always works as well. This is especially important when switching to namespaced classes.Additionally I had the idea, that we can offer the
SimplePie.compiled.phpdirectly as an asset for download at a release. I have created a separate Github workflow for this purpose.This PR could also potentially fix #544.