Return effective feed URL when asking for non-permanent subscribe_url#627
Merged
mblaney merged 3 commits intosimplepie:masterfrom Oct 7, 2019
Merged
Return effective feed URL when asking for non-permanent subscribe_url#627mblaney merged 3 commits intosimplepie:masterfrom
mblaney merged 3 commits intosimplepie:masterfrom
Conversation
This was referenced Oct 4, 2019
Member
|
hi @jtojnar thanks for this, I notice you've added |
d85ff41 to
a802603
Compare
Member
Author
|
Right, forgot to stage a new file again. I really need to start using something like https://github.com/hyperfekt/git-stagelight |
jtojnar
commented
Oct 7, 2019
Member
|
@jtojnar your new test raises a notice, would you mind looking in to that too? |
No tests really tried to parse this before but the prolog was invalid: https://www.w3.org/TR/REC-xml/#NT-XMLDecl
a802603 to
50a26be
Compare
Atom feeds should have a namespace declared.
50a26be to
0e0846b
Compare
Member
Author
|
Fixed the |
0e0846b to
f97ef52
Compare
This comment has been minimized.
This comment has been minimized.
`subscribe_url` method supports two modes: permanent and non-permanent. And while the URL for the first one is obtained from the `File` after it has been fetched, discounting auto-discovery, the latter one remains the same from the time `set_feed_url` was called. Because even the permanent mode concerns itself with redirection (although limited to a potential 301 as a first link in the chain), I would expect the non-permanent one to care doubly so. This patch enables just that – after the feed is fetched, url property is updated, regardless of auto-discovery being done.
f97ef52 to
59149ef
Compare
Member
|
Nice one @jtojnar thanks for the extra work! :-) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
subscribe_urlmethod supports two modes: permanent and non-permanent. And while the URL for the first one is obtained from theFileafter it has been fetched, discounting auto-discovery, the latter one remains the same from the timeset_feed_urlwas called.Because even the permanent mode concerns itself with redirection (although limited to a potential 301 as a first link in the chain), I would expect the non-permanent one to care doubly so.
This patch enables just that – after the feed is fetched, url property is updated, regardless of auto-discovery being done.
Fixes: #2