Skip to content

Faster atan2 #329

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
runger1101001 merged 1 commit into from
Oct 29, 2023
Merged

Faster atan2 #329

runger1101001 merged 1 commit into from
Oct 29, 2023

Conversation

@Candas1
Copy link
Collaborator

@Candas1 Candas1 commented Oct 23, 2023

Shamelessly copied, even the credits (see the comments)

Before:
RAM: [= ] 9.0% (used 4444 bytes from 49152 bytes)
Flash: [=== ] 26.9% (used 70592 bytes from 262144 bytes)

up to 48us

After:
RAM: [= ] 9.0% (used 4444 bytes from 49152 bytes)
Flash: [=== ] 26.7% (used 69912 bytes from 262144 bytes)

up to 28us

Reduces memory usage and almost twice as fast on a STM32F1
It's not used in the SVPWM anymore but can be useful for other features.
I am using it in the flux observer sensor.

@runger1101001
Copy link
Member

runger1101001 commented Oct 29, 2023

Hmmm...

/home/runner/Arduino/libraries/Arduino-FOC/src/current_sense/hardware_specific/esp32/esp32_adc_driver.cpp:9:10: fatal error: esp_intr.h: No such file or directory
    9 | #include "esp_intr.h"
      |          ^~~~~~~~~~~~
compilation terminated.

That doesn't really look like it has to do with your change...

So I will merge this, it is compiling for all other platforms except ESP32.

@runger1101001 runger1101001 merged commit bc2349b into simplefoc:dev Oct 29, 2023
@runger1101001 runger1101001 added this to the 2.3.2_Release milestone Dec 1, 2023
@Candas1 Candas1 deleted the faster_atan2 branch January 29, 2024 19:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

2.3.2_Release

Development

Successfully merging this pull request may close these issues.

2 participants

@Candas1 @runger1101001