Claude finished @simonw's task —— View job

PR Review Complete ✅

I've reviewed the PDF mobile blur fix. Here's my comprehensive feedback:

• Analyze the changed file (view-pdf.html)
• Review code quality and implementation approach
• Check for potential bugs or edge cases
• Evaluate performance impact
• Assess security considerations
• Consider test coverage needs
• Provide comprehensive feedback

Code Quality & Implementation ✅

Excellent approach. The fix correctly addresses the high-DPI canvas rendering issue by:

• Using devicePixelRatio to scale canvas internal resolution
• Setting CSS dimensions to maintain logical size
• Applying context scaling to match device pixel ratio

This is the standard solution for crisp canvas rendering on high-DPI displays.

Technical Review

Lines 317-323 (view-pdf.html:317-323):

const dpr = window.devicePixelRatio || 1;
canvas.width = Math.floor(viewport.width * dpr);
canvas.height = Math.floor(viewport.height * dpr);
canvas.style.width = viewport.width + 'px';
canvas.style.height = viewport.height + 'px';
context.scale(dpr, dpr);

Strengths:

• ✅ Proper fallback (|| 1) for older browsers
• ✅ Math.floor() prevents subpixel rendering artifacts
• ✅ Separates internal resolution from visual size via CSS
• ✅ Context scaling ensures PDF.js renders at correct scale

Potential Issues & Improvements

Minor Edge Cases:

1. Dynamic DPR changes: Some devices can change DPR (e.g., external monitors). Consider listening to window.matchMedia('screen and (resolution: 2dppx)') changes for robustness.

2. Memory usage: High-DPI rendering increases canvas memory usage by ~4-9x (2x-3x DPR squared). For large PDFs, this could impact performance on memory-constrained devices.

Performance Impact: 📈

• Positive: Eliminates browser upscaling blur, improving perceived performance
• Trade-off: Slightly higher memory usage and render time, but negligible for typical PDFs

Security Assessment ✅

No security concerns. The change only affects canvas rendering dimensions and doesn't introduce any new attack vectors.

Test Coverage Considerations

The change affects visual rendering quality, which is difficult to unit test. Consider:

• Manual testing: Verify on actual high-DPI devices (iOS Safari, Android Chrome)
• Visual regression testing: If using tools like Playwright, capture screenshots on different DPR values

Recommendation: APPROVE ✅

This is a well-implemented fix for a common high-DPI canvas issue. The code follows best practices and the performance trade-offs are reasonable for the visual quality improvement gained.

Suggested follow-up (optional): Consider adding a comment explaining the DPR scaling for future maintainers.

Deploying tools with    Cloudflare Pages

View logs

Before screenshot:

After: