Escape the table name in populate_fts and search.#56
Closed
amjith wants to merge 1 commit intosimonw:masterfrom
Closed
Escape the table name in populate_fts and search.#56amjith wants to merge 1 commit intosimonw:masterfrom
amjith wants to merge 1 commit intosimonw:masterfrom
Conversation
simonw
reviewed
Sep 2, 2019
| INSERT INTO "{table}_fts" (rowid, {columns}) | ||
| SELECT rowid, {columns} FROM {table}; | ||
| SELECT rowid, {columns} FROM "{table}"; | ||
| """.format( |
Owner
There was a problem hiding this comment.
I've been using [...] escaping instead of "..." escaping elsewhere, so let's do that here as well for consistency.
Owner
|
Good spot, thanks! Would be useful to add a test as well, derived from your above example. |
Contributor
Author
|
I have updated the other PR with the changes from this one and added tests. I have also changed the escaping from double quotes to brackets. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The table names weren't escaped using double quotes in the populate_fts method.
Reproducible case: