bump uvicorn to 0.9.0 to be Python-3.8 friendly#595
bump uvicorn to 0.9.0 to be Python-3.8 friendly#595stonebig wants to merge 1 commit intosimonw:masterfrom
Conversation
as uvicorn-0.9 is needed to get websockets-8.0.2, which is needed to have Python-3.8 compatibility
|
Ooh this is tricky... https://travis-ci.org/simonw/datasette/jobs/597216285 failed because it looks like This is a problem. I need to keep Datasette working with 3.5 for compatibility with Glitch. But obviously I also want it to work with 3.8. I wonder if there's a smart solution here. @tomchristie any thoughts? |
|
Maybe make the setup rule conditional, so that below python-3.6, it looks for unicorn-0.8 ? |
|
🤷♂️ @stonebig's suggestion would be the best I got too, if you want to support 3.5->3.8. It's either that, or hold off on 3.8 support until you're ready to go to 3.6->3.8. |
|
There more discussion around this on the Glitch forums here: https://support.glitch.com/t/can-you-upgrade-python-to-latest-version/7980 |
|
I like the conditional dependency for the moment - maybe until 3.5 becomes officially unsupported. |
|
Glitch has been upgraded to Python 3.7. I think I'm happy to drop 3.5 support now - users who want Python 3.5 can get it by installing |
Whoop! 🥳 ✨ |
|
Closing this in favour of #627 which upgrades to uvicorn 0.10.4 |
as uvicorn-0.9 is needed to get websockets-8.0.2, which is needed to have Python-3.8 compatibility