use single quotes for string literals, fixes #2001#2004
Open
cldellow wants to merge 1 commit intosimonw:mainfrom
Open
use single quotes for string literals, fixes #2001#2004cldellow wants to merge 1 commit intosimonw:mainfrom
cldellow wants to merge 1 commit intosimonw:mainfrom
Conversation
Codecov ReportBase: 92.11% // Head: 92.11% // No change to project coverage 👍
Additional details and impacted files@@ Coverage Diff @@
## main #2004 +/- ##
=======================================
Coverage 92.11% 92.11%
=======================================
Files 38 38
Lines 5555 5555
=======================================
Hits 5117 5117
Misses 438 438
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This modernizes some uses of double quotes for string literals to use only single quotes, fixes #2001
While developing it, I manually enabled the stricter mode by using the code snippet at https://gist.github.com/cldellow/85bba507c314b127f85563869cd94820
I think that code snippet isn't generally safe/portable, so I haven't tried to automate it in the tests.
📚 Documentation preview 📚: https://datasette--2004.org.readthedocs.build/en/2004/