Skip to content

Use click.echo() instead of print() for --root option#1961

Merged
simonw merged 1 commit intomainfrom
click-echo-root
Dec 16, 2022
Merged

Use click.echo() instead of print() for --root option#1961
simonw merged 1 commit intomainfrom
click-echo-root

Conversation

@simonw
Copy link
Owner

@simonw simonw commented Dec 16, 2022

This ensures the URL is output correctly when running under Docker.

Closes #1958


📚 Documentation preview 📚: https://datasette--1961.org.readthedocs.build/en/1961/

@simonw simonw added the bug label Dec 16, 2022
@simonw simonw marked this pull request as ready for review December 16, 2022 00:54
@simonw simonw merged commit 0134968 into main Dec 16, 2022
@simonw simonw deleted the click-echo-root branch December 16, 2022 00:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

datasette --root running in Docker doesn't reliably show the magic URL

1 participant