Ensure template_path always uses "/" to match jinja#1617
Merged
simonw merged 2 commits intosimonw:mainfrom Feb 3, 2022
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## main #1617 +/- ##
==========================================
+ Coverage 92.09% 92.16% +0.06%
==========================================
Files 34 34
Lines 4518 4531 +13
==========================================
+ Hits 4161 4176 +15
+ Misses 357 355 -2
Continue to review full report at Codecov.
|
Owner
|
Aha I understand the problem now! pallets/jinja#1378 (comment)
|
Owner
|
I was hoping to get the test suite running on Windows before merging this PR but that looks like it will be a BIG job, see: So I'm going to merge this one as-is for the moment. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR shoudl fix #1545
The existing code substituted / for , assuming this was the right behaviour for windows. But on Windows, Jinja still uses / for the template list - See https://github.com/pallets/jinja/blob/896a62135bcc151f2997e028c5125bec2cb2431f/src/jinja2/loaders.py#L225