Ensure db.path is a string before trying to insert into internal database#1370
Merged
simonw merged 1 commit intosimonw:mainfrom Jun 21, 2021
Merged
Ensure db.path is a string before trying to insert into internal database#1370simonw merged 1 commit intosimonw:mainfrom
simonw merged 1 commit intosimonw:mainfrom
Conversation
Owner
|
We can remove a bunch of unnecessary |
Contributor
Author
|
I'm happy to grab some or all of these in this PR, if you want. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1365
This is the simplest possible fix, with a test that will fail without it. There are a bunch of places where
db.pathis getting converted to and from aPathtype, so this fix errs on the side of callingstr(db.path)right before it's inserted.