Skip to content

Fix startup error on windows#1128

Merged
simonw merged 1 commit intosimonw:mainfrom
abdusco:patch-1
Dec 5, 2020
Merged

Fix startup error on windows#1128
simonw merged 1 commit intosimonw:mainfrom
abdusco:patch-1

Conversation

@abdusco
Copy link
Contributor

@abdusco abdusco commented Dec 4, 2020

Fixes #1094

This import isn't used at all, and causes error on startup on Windows.

Fixes simonw#1094

This import isn't used at all, and causes error on startup on Windows.
@codecov
Copy link

codecov bot commented Dec 4, 2020

Codecov Report

Merging #1128 (7004c3b) into main (49d8fc0) will decrease coverage by 0.00%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1128      +/-   ##
==========================================
- Coverage   91.42%   91.42%   -0.01%     
==========================================
  Files          31       31              
  Lines        3873     3872       -1     
==========================================
- Hits         3541     3540       -1     
  Misses        332      332              
Impacted Files Coverage Δ
datasette/utils/asgi.py 92.13% <ø> (-0.04%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 49d8fc0...7004c3b. Read the comment docs.

@simonw
Copy link
Owner

simonw commented Dec 5, 2020

Thanks for this!

@simonw simonw merged commit 705d1a1 into simonw:main Dec 5, 2020
@abdusco abdusco deleted the patch-1 branch December 6, 2020 08:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

import EX_CANTCREAT means datasette fails to work on Windows

2 participants