Need to figure out the --setting foo bar alternative for this --config foo:bar logic:

Lines 31 to 63 in 4bac9f1

    
           class Config(click.ParamType): 
        
               name = "config" 
        
               def convert(self, config, param, ctx): 
        
                   if ":" not in config: 
        
                       self.fail(f'"{config}" should be name:value', param, ctx) 
        
                       return 
        
                   name, value = config.split(":", 1) 
        
                   if name not in DEFAULT_CONFIG: 
        
                       self.fail( 
        
                           f"{name} is not a valid option (--help-config to see all)", 
        
                           param, 
        
                           ctx, 
        
                       ) 
        
                       return 
        
                   # Type checking 
        
                   default = DEFAULT_CONFIG[name] 
        
                   if isinstance(default, bool): 
        
                       try: 
        
                           return name, value_as_boolean(value) 
        
                       except ValueAsBooleanError: 
        
                           self.fail(f'"{name}" should be on/off/true/false/1/0', param, ctx) 
        
                           return 
        
                   elif isinstance(default, int): 
        
                       if not value.isdigit(): 
        
                           self.fail(f'"{name}" should be an integer', param, ctx) 
        
                           return 
        
                       return name, int(value) 
        
                   elif isinstance(default, str): 
        
                       return name, value 
        
                   else: 
        
                       # Should never happen: 
        
                       self.fail("Invalid option")

	class Config(click.ParamType):
	name = "config"

	def convert(self, config, param, ctx):
	if ":" not in config:
	self.fail(f'"{config}" should be name:value', param, ctx)
	return
	name, value = config.split(":", 1)
	if name not in DEFAULT_CONFIG:
	self.fail(
	f"{name} is not a valid option (--help-config to see all)",
	param,
	ctx,
	)
	return
	# Type checking
	default = DEFAULT_CONFIG[name]
	if isinstance(default, bool):
	try:
	return name, value_as_boolean(value)
	except ValueAsBooleanError:
	self.fail(f'"{name}" should be on/off/true/false/1/0', param, ctx)
	return
	elif isinstance(default, int):
	if not value.isdigit():
	self.fail(f'"{name}" should be an integer', param, ctx)
	return
	return name, int(value)
	elif isinstance(default, str):
	return name, value
	else:
	# Should never happen:
	self.fail("Invalid option")

Uh oh!

Change "--config foo:bar" to "--setting foo bar" #992

Description

Metadata

Metadata

Assignees

Labels

Projects

Milestone

Relationships

Development

Issue actions