Skip to content

Initial add simple prod ready Dockerfile refs #57#94

Merged
simonw merged 1 commit intosimonw:masterfrom
macropin:master
Nov 15, 2017
Merged

Initial add simple prod ready Dockerfile refs #57#94
simonw merged 1 commit intosimonw:masterfrom
macropin:master

Conversation

@macropin
Copy link
Contributor

@macropin macropin commented Nov 14, 2017

Multi-stage build based off official python:3.6-slim

Example usage:

docker run --rm -t -i -p 9000:8001 -v $(pwd)/db:/db datasette datasette serve /db/chinook.db

@simonw
Copy link
Owner

simonw commented Nov 15, 2017

Works for me. I'm going to land this.

Just one thing:

simonw$ docker run --rm -t -i -p 9001:8001 c408e8cfbe40 datasette publish now
 The publish command requires "now" to be installed and configured 
Follow the instructions at https://zeit.co/now#whats-now

Maybe we should have the Docker container install the "now" client? Not sure how much size that would add though. I think it's OK without for the moment.

@simonw simonw merged commit 8675550 into simonw:master Nov 15, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@macropin @simonw