The bug is here:

Lines 89 to 100 in 13b3b51

    
           def _execute_writes(self): 
        
               # Infinite looping thread that protects the single write connection 
        
               # to this database 
        
               conn = self.connect(write=True) 
        
               while True: 
        
                   task = self._write_queue.get() 
        
                   try: 
        
                       result = task.fn(conn) 
        
                   except Exception as e: 
        
                       print(e) 
        
                       result = e 
        
                   task.reply_queue.sync_q.put(result)

If conn = self.connect(write=True) raises an exception the entire server hangs, like this:

% datasette -i fixtures.db  --get /            
Exception in thread Thread-1:
Traceback (most recent call last):
  File "/usr/local/opt/python@3.8/Frameworks/Python.framework/Versions/3.8/lib/python3.8/threading.py", line 932, in _bootstrap_inner
    self.run()
  File "/usr/local/opt/python@3.8/Frameworks/Python.framework/Versions/3.8/lib/python3.8/threading.py", line 870, in run
    self._target(*self._args, **self._kwargs)
  File "/Users/simon/.local/share/virtualenvs/latest-datasette-with-all-plugins-PJL_Xy9e/lib/python3.8/site-packages/datasette/database.py", line 92, in _execute_writes
    conn = self.connect(write=True)
  File "/Users/simon/.local/share/virtualenvs/latest-datasette-with-all-plugins-PJL_Xy9e/lib/python3.8/site-packages/datasette/database.py", line 55, in connect
    assert not (write and not self.is_mutable)
AssertionError

... server hangs here ...

	def _execute_writes(self):
	# Infinite looping thread that protects the single write connection
	# to this database
	conn = self.connect(write=True)
	while True:
	task = self._write_queue.get()
	try:
	result = task.fn(conn)
	except Exception as e:
	print(e)
	result = e
	task.reply_queue.sync_q.put(result)

Uh oh!

db.execute_write_fn(create_tables, block=True) hangs a thread if connection fails #935

Description

Metadata

Metadata

Assignees

Labels

Projects

Milestone

Relationships

Development

Issue actions