Skip to content

datasette.add_message() doesn't work inside plugins #864

New issue
New issue
Closed
Closed
datasette.add_message() doesn't work inside plugins#864
Labels
bugplugins
Milestone
Datasette 0.45
@simonw

Description

@simonw
simonw
opened on Jun 24, 2020

Similar problem to #863 - calling datasette.add_message() in a view registered using the register_routes() plugin hook doesn't work, because the code that writes accumulated messages to the ds_messages signed cookie lives in the BaseView class here:

datasette/datasette/views/base.py

Lines 94 to 97 in 28bb1c5

response = await super().dispatch_request(request, *args, **kwargs)
if self.ds:
self.ds._write_messages_to_response(request, response)
return response

Metadata

Metadata

Assignees

No one assigned

    Labels

    bugplugins

    Projects

    No projects

    Milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions