Skip to content

Respect default scope["actor"] if one exists #854

New issue
New issue
Closed
Closed
Respect default scope["actor"] if one exists#854
Labels
authentication-and-permissionspluginssmall
Milestone
Datasette 0.45
@simonw

Description

@simonw
simonw
opened on Jun 18, 2020

ASGI wrapper plugins that themselves set the actor scope variable should be respected (though actor_from_request plugins should still execute and get the chance to replace that initial actor value).

Relevant code:

datasette/datasette/app.py

Lines 910 to 921 in 09a3479

# Handle authentication
actor = None
for actor in pm.hook.actor_from_request(
datasette=self.ds, request=Request(scope, receive)
):
if callable(actor):
actor = actor()
if asyncio.iscoroutine(actor):
actor = await actor
if actor:
break
scope_modifications["actor"] = actor

Metadata

Metadata

Assignees

No one assigned

    Labels

    authentication-and-permissionspluginssmall

    Projects

    No projects

    Milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions