request.url and request.scheme should obey force_https_urls config setting

I'm trying to get the https://www.niche-museums.com/browse/feed.atom feed to validate and I git this from https://validator.w3.org/feed/check.cgi?url=https%3A%2F%2Fwww.niche-museums.com%2Fbrowse%2Ffeed.atom

> This feed is valid, but interoperability with the widest range of feed readers could be improved by implementing the following recommendations.
> 
> [line 6](https://validator.w3.org/feed/check.cgi?url=https%3A%2F%2Fwww.niche-museums.com%2Fbrowse%2Ffeed.atom#l6), column 73: Self reference doesn't match document location [[help](https://validator.w3.org/feed/docs/warning/SelfDoesntMatchLocation.html "more information about this error")]
> 
>     <link href="http://www.niche-museums.com/browse/feed.atom" rel="self"/>

I tried to fix this using `force_https_urls` ([commit](https://github.com/simonw/museums/commit/5dc8e2c717c59f9e949b65e47a59878e01f929e4)) but it didn't work - because that setting isn't respected by the Request class:

https://github.com/simonw/datasette/blob/40885ef24e32d91502b6b8bbad1c7376f50f2830/datasette/utils/asgi.py#L15-L32

	class Request:
	def __init__(self, scope, receive):
	self.scope = scope
	self.receive = receive

	@property
	def method(self):
	return self.scope["method"]

	@property
	def url(self):
	return urlunparse(
	(self.scheme, self.host, self.path, None, self.query_string, None)
	)

	@property
	def scheme(self):
	return self.scope.get("scheme") or "http"

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

request.url and request.scheme should obey force_https_urls config setting #781

Metadata

Assignees

Labels

Projects

Milestone

Relationships

Development

Uh oh!

request.url and request.scheme should obey force_https_urls config setting #781

Description

Metadata

Metadata

Assignees

Labels

Projects

Milestone

Relationships

Development

Issue actions