Skip to content

--plugin-secret over-rides existing metadata.json plugin config #724

New issue
New issue
Closed
Closed
--plugin-secret over-rides existing metadata.json plugin config#724
Labels
bugdatasette-publishmetadata
@simonw

Description

@simonw
simonw
opened on Apr 10, 2020

This means if you use --plugin-secret at all (with e.g. publish cloudrun) any existing plugin configuration in your metadata.json will be ignored.

datasette/datasette/publish/cloudrun.py

Lines 98 to 109 in af9cd4c

if plugin_secret:
extra_metadata["plugins"] = {}
for plugin_name, plugin_setting, setting_value in plugin_secret:
environment_variable = (
"{}_{}".format(plugin_name, plugin_setting)
.upper()
.replace("-", "_")
)
environment_variables[environment_variable] = setting_value
extra_metadata["plugins"].setdefault(plugin_name, {})[
plugin_setting
] = {"$env": environment_variable}

Metadata

Metadata

Assignees

No one assigned

    Labels

    bugdatasette-publishmetadata

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions