Skip to content

"Templates considered" comment broken in >=0.35 #689

@chrishas35

Description

@chrishas35

Noticed that the "Templates Considered" comment is missing in 0.37. Believe I traced it back to #664 as you can see it in https://v0-34.datasette.io/ but not https://v0-35.datasette.io/. Looking at the template context debug between the two you can see what is missing from 0.35 vs. 0.34:

<     "datasette_version": "0.34",
<     "app_css_hash": "ffa51a",
<     "select_templates": [
<         "*index.html"
<     ],
<     "zip": "<class 'zip'>",
<     "body_scripts": [],
<     "extra_css_urls": "<generator object BaseView._asset_urls at 0x7f6529ac05f0>",
<     "extra_js_urls": "<generator object BaseView._asset_urls at 0x7f6529ac0660>",
<     "format_bytes": "<function format_bytes at 0x7f652a1588b0>",
<     "database_url": "<bound method BaseView.database_url of <datasette.views.index.IndexView object at 0x7f6529b03e50>>",
<     "database_color": "<bound method BaseView.database_color of <datasette.views.index.IndexView object at 0x7f6529b03e50>>"
---
>     "datasette_version": "0.35",
>     "database_url": "<bound method BaseView.database_url of <datasette.views.index.IndexView object at 0x7f6140dacd90>>",
>     "database_color": "<bound method BaseView.database_color of <datasette.views.index.IndexView object at 0x7f6140dacd90>>"

Metadata

Metadata

Assignees

No one assigned

    Labels

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions