Conversation
Owner
Author
Contributor
|
That looks right, and I completely agree with the intent. |
Contributor
|
The only negative impact that comes to mind is that now you have no way to get the read-only query to be formatted nicely, I think, so maybe a second PR adding the formatting functionality even to the read-only page would be good? |
Owner
Author
|
That's a good idea. It could even be smart about it and only show the "Format SQL" button on that page of the output of the function would differ from what's there already. |
rixx
added a commit
to rixx/datasette
that referenced
this pull request
Oct 20, 2019
Following discussion in simonw#601, this PR adds a "Format SQL" button to read-only SQL (if the SQL actually differs from the formatting result). It also removes a console error on readonly SQL queries.
Contributor
|
Submitted in #602! |
simonw
pushed a commit
that referenced
this pull request
Nov 4, 2019
simonw
added a commit
that referenced
this pull request
Nov 11, 2019
simonw
pushed a commit
that referenced
this pull request
Nov 11, 2019
simonw
added a commit
that referenced
this pull request
Nov 15, 2019
simonw
pushed a commit
that referenced
this pull request
Nov 15, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refs #600