Skip to content

Datasette on Zeit Now returns http URLs for facet and next links #333

@simonw

Description

@simonw

e.g. on https://fivethirtyeight.datasettes.com/fivethirtyeight-ac35616/nba-elo%2Fnbaallelo.json?_facet=lg_id&_size=0

{
  "facet_results": {
    "lg_id": {
      "name": "lg_id",
      "results": [
        {
          "value": "NBA",
          "label": "NBA",
          "count": 118016,
          "toggle_url": "http://fivethirtyeight.datasettes.com/fivethirtyeight-ac35616/nba-elo%2Fnbaallelo.json?_facet=lg_id&_size=1&lg_id=NBA",
          "selected": false
        },
        {
          "value": "ABA",
          "label": "ABA",
          "count": 8298,
          "toggle_url": "http://fivethirtyeight.datasettes.com/fivethirtyeight-ac35616/nba-elo%2Fnbaallelo.json?_facet=lg_id&_size=1&lg_id=ABA",
          "selected": false
        }
      ],
      "truncated": false
    }
  },
  "suggested_facets": [
    {
      "name": "_iscopy",
      "toggle_url": "/fivethirtyeight-ac35616/nba-elo%2Fnbaallelo.json?_facet=lg_id&_size=1&_facet=_iscopy"
    }
  ],
  "next_url": "http://fivethirtyeight.datasettes.com/fivethirtyeight-ac35616/nba-elo%2Fnbaallelo.json?_facet=lg_id&_size=1&_next=1",
}

next_url and facet_results both link to http:// when they should link to https://.

Note that suggested facets doesn't include the full URL at all, which is a consistency bug.

Metadata

Metadata

Assignees

No one assigned

    Labels

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions