-
-
Notifications
You must be signed in to change notification settings - Fork 813
Closed
Labels
Description
Currently:
just lint
Returns:
./datasette/app.py:9:5: F401 'datasette.permissions.AllowedResource' imported but unused
./datasette/app.py:1147:29: F541 f-string is missing placeholders
./datasette/app.py:1521:50: E203 whitespace before ':'
./datasette/app.py:2140:44: E203 whitespace before ':'
./datasette/app.py:2233:68: E203 whitespace before ':'
./datasette/cli.py:857:38: E203 whitespace before ':'
./datasette/default_permissions/__init__.py:28:1: F401 '.restrictions.actor_restrictions_sql' imported but unused
./datasette/default_permissions/__init__.py:28:1: F401 '.restrictions.restrictions_allow_action' imported but unused
./datasette/default_permissions/__init__.py:28:1: F401 '.restrictions.ActorRestrictions' imported but unused
./datasette/default_permissions/__init__.py:33:1: F401 '.root.root_user_permissions_sql' imported but unused
./datasette/default_permissions/__init__.py:34:1: F401 '.config.config_permissions_sql' imported but unused
./datasette/default_permissions/__init__.py:35:1: F401 '.defaults.default_allow_sql_check' imported but unused
./datasette/default_permissions/__init__.py:35:1: F401 '.defaults.default_action_permissions_sql' imported but unused
./datasette/default_permissions/__init__.py:35:1: F401 '.defaults.DEFAULT_ALLOW_ACTIONS' imported but unused
./datasette/default_permissions/__init__.py:40:1: F401 '.tokens.actor_from_signed_api_token' imported but unused
./datasette/default_permissions/tokens.py:48:41: E203 whitespace before ':'
./datasette/default_permissions/tokens.py:53:30: E203 whitespace before ':'
./datasette/facets.py:46:42: E203 whitespace before ':'
./datasette/views/base.py:4:1: F401 'json' imported but unused
./datasette/views/special.py:323:41: E203 whitespace before ':'
./datasette/views/special.py:742:56: E203 whitespace before ':'
./datasette/views/table.py:1633:31: E203 whitespace before ':'
./tests/test_allowed_resources.py:120:9: F841 local variable 'production_tables' is assigned to but never used
./tests/test_api.py:576:40: F811 redefinition of unused 'app_client_no_files' from line 4
./tests/test_api.py:617:35: F811 redefinition of unused 'app_client_no_files' from line 4
./tests/test_api.py:623:54: F811 redefinition of unused 'app_client_with_dot' from line 4
./tests/test_api.py:648:25: F811 redefinition of unused 'app_client_shorter_time_limit' from line 4
./tests/test_api.py:812:25: F811 redefinition of unused 'app_client_two_attached_databases_one_immutable' from line 4
./tests/test_api.py:818:17: E711 comparison to None should be 'if cond is None:'
./tests/test_api.py:819:17: E712 comparison to True should be 'if cond is True:' or 'if cond:'
./tests/test_api.py:820:18: E712 comparison to False should be 'if cond is False:' or 'if not cond:'
./tests/test_api.py:824:18: E712 comparison to False should be 'if cond is False:' or 'if not cond:'
./tests/test_api.py:825:18: E712 comparison to False should be 'if cond is False:' or 'if not cond:'
./tests/test_api.py:977:28: F811 redefinition of unused 'app_client_larger_cache_size' from line 4
./tests/test_api.py:1013:5: F811 redefinition of unused 'app_client_with_cors' from line 4
./tests/test_api.py:1014:5: F811 redefinition of unused 'app_client_two_attached_databases_one_immutable' from line 4
./tests/test_api.py:1058:38: F811 redefinition of unused 'app_client_two_attached_databases' from line 4
./tests/test_api.py:1065:39: F811 redefinition of unused 'app_client_conflicting_database_names' from line 4
./tests/test_api.py:1076:38: F811 redefinition of unused 'app_client_immutable_and_inspect_file' from line 4
./tests/test_api.py:1091:24: F811 redefinition of unused 'app_client' from line 4
./tests/test_api_write.py:272:9: E266 too many leading '#' for block comment
./tests/test_auth.py:323:55: E203 whitespace before ':'
./tests/test_config_dir.py:90:13: F841 local variable 'ds' is assigned to but never used
./tests/test_crossdb.py:70:5: F841 local variable 'response2' is assigned to but never used
./tests/test_csv.py:68:33: F811 redefinition of unused 'app_client_with_cors' from line 4
./tests/test_csv.py:167:161: E501 line too long (190 > 160 characters)
./tests/test_csv.py:168:161: E501 line too long (190 > 160 characters)
./tests/test_csv.py:197:161: E501 line too long (256 > 160 characters)
./tests/test_csv.py:205:21: F811 redefinition of unused 'app_client_csv_max_mb_one' from line 4
./tests/test_csv.py:246:20: F811 redefinition of unused 'app_client_with_trace' from line 4
./tests/test_csv.py:257:53: F811 redefinition of unused 'app_client_with_trace' from line 4
./tests/test_csv.py:263:53: F811 redefinition of unused 'app_client_with_trace' from line 4
./tests/test_filters.py:107:1: F811 redefinition of unused 'test_through_filters_from_request' from line 86
./tests/test_html.py:21:19: F811 redefinition of unused 'app_client_two_attached_databases' from line 4
./tests/test_html.py:205:25: F811 redefinition of unused 'app_client_shorter_time_limit' from line 4
./tests/test_html.py:528:51: F811 redefinition of unused 'app_client' from line 4
./tests/test_html.py:734:161: E501 line too long (260 > 160 characters)
./tests/test_html.py:737:161: E501 line too long (260 > 160 characters)
./tests/test_html.py:752:161: E501 line too long (161 > 160 characters)
./tests/test_html.py:848:26: F811 redefinition of unused 'app_client_base_url_prefix' from line 4
./tests/test_html.py:878:52: E203 whitespace before ':'
./tests/test_html.py:891:44: F811 redefinition of unused 'app_client_base_url_prefix' from line 4
./tests/test_html.py:901:51: F811 redefinition of unused 'app_client_base_url_prefix' from line 4
./tests/test_html.py:912:161: E501 line too long (293 > 160 characters)
./tests/test_html.py:916:161: E501 line too long (296 > 160 characters)
./tests/test_internals_datasette.py:161:9: F841 local variable 'ds' is assigned to but never used
./tests/test_permissions.py:5:1: F401 '.fixtures.app_client' imported but unused
./tests/test_permissions.py:372:30: F811 redefinition of unused 'app_client' from line 5
./tests/test_permissions.py:1484:5: F841 local variable 'data' is assigned to but never used
./tests/test_plugins.py:14:1: F401 'datasette.permissions.Action' imported but unused
./tests/test_plugins.py:15:1: F401 'datasette.resources.DatabaseResource' imported but unused
./tests/test_plugins.py:495:161: E501 line too long (170 > 160 characters)
./tests/test_plugins.py:573:161: E501 line too long (170 > 160 characters)
./tests/test_plugins.py:1175:5: F811 redefinition of unused 'Action' from line 14
./tests/test_plugins.py:1176:5: F401 'datasette.resources.InstanceResource' imported but unused
./tests/test_plugins.py:1176:5: F811 redefinition of unused 'DatabaseResource' from line 15
./tests/test_plugins.py:1530:1: F811 redefinition of unused 'test_hook_register_actions' from line 1174
./tests/test_plugins.py:1548:5: F811 redefinition of unused 'Action' from line 14
./tests/test_restriction_sql.py:185:5: F841 local variable 'db1' is assigned to but never used
./tests/test_restriction_sql.py:186:5: F841 local variable 'db2' is assigned to but never used
./tests/test_schema_endpoints.py:1:1: F401 'asyncio' imported but unused
./tests/test_table_api.py:725:5: F811 redefinition of unused 'app_client_returned_rows_matches_page_size' from line 3
./tests/test_table_api.py:1052:45: F811 redefinition of unused 'app_client_with_trace' from line 3
./tests/test_table_html.py:676:161: E501 line too long (165 > 160 characters)
./tests/test_table_html.py:896:161: E501 line too long (164 > 160 characters)
./tests/test_table_html.py:901:161: E501 line too long (164 > 160 characters)
./tests/test_table_html.py:1266:5: F841 local variable 'blah' is assigned to but never used
./tests/test_table_html.py:1297:58: F811 redefinition of unused 'app_client_with_dot' from line 3
./tests/test_utils.py:142:161: E501 line too long (176 > 160 characters)
./tests/test_utils_permissions.py:45:161: E501 line too long (185 > 160 characters)
./tests/test_utils_permissions.py:448:161: E501 line too long (187 > 160 characters)
error: Recipe `lint` failed on line 23 with exit code 1
Reactions are currently unavailable