datasette/datasette/app.py

Lines 880 to 897 in 209bdee

    
           def _prepare_connection(self, conn, database): 
        
               conn.row_factory = sqlite3.Row 
        
               conn.text_factory = lambda x: str(x, "utf-8", "replace") 
        
               if self.sqlite_extensions and database != INTERNAL_DB_NAME: 
        
                   conn.enable_load_extension(True) 
        
                   for extension in self.sqlite_extensions: 
        
                       # "extension" is either a string path to the extension 
        
                       # or a 2-item tuple that specifies which entrypoint to load. 
        
                       if isinstance(extension, tuple): 
        
                           path, entrypoint = extension 
        
                           conn.execute("SELECT load_extension(?, ?)", [path, entrypoint]) 
        
                       else: 
        
                           conn.execute("SELECT load_extension(?)", [extension]) 
        
               if self.setting("cache_size_kb"): 
        
                   conn.execute(f"PRAGMA cache_size=-{self.setting('cache_size_kb')}") 
        
               # pylint: disable=no-member 
        
               if database != INTERNAL_DB_NAME: 
        
                   pm.hook.prepare_connection(conn=conn, database=database, datasette=self)

I set it up to skip both loading SQLite extensions and running the prepare_connection() hook for that internal database.

	def _prepare_connection(self, conn, database):
	conn.row_factory = sqlite3.Row
	conn.text_factory = lambda x: str(x, "utf-8", "replace")
	if self.sqlite_extensions and database != INTERNAL_DB_NAME:
	conn.enable_load_extension(True)
	for extension in self.sqlite_extensions:
	# "extension" is either a string path to the extension
	# or a 2-item tuple that specifies which entrypoint to load.
	if isinstance(extension, tuple):
	path, entrypoint = extension
	conn.execute("SELECT load_extension(?, ?)", [path, entrypoint])
	else:
	conn.execute("SELECT load_extension(?)", [extension])
	if self.setting("cache_size_kb"):
	conn.execute(f"PRAGMA cache_size=-{self.setting('cache_size_kb')}")
	# pylint: disable=no-member
	if database != INTERNAL_DB_NAME:
	pm.hook.prepare_connection(conn=conn, database=database, datasette=self)

Uh oh!

prepare_connection() shouldn't run against the internal database #2468

Description

Metadata

Metadata

Assignees

Labels

Projects

Milestone

Relationships

Development

Issue actions