We do have a count time limit elsewhere, but that's for listing tables:

Lines 370 to 390 in 7d8dd2a

    
           async def table_counts(self, limit=10): 
        
               if not self.is_mutable and self.cached_table_counts is not None: 
        
                   return self.cached_table_counts 
        
               # Try to get counts for each table, $limit timeout for each count 
        
               counts = {} 
        
               for table in await self.table_names(): 
        
                   try: 
        
                       table_count = ( 
        
                           await self.execute( 
        
                               f"select count(*) from [{table}]", 
        
                               custom_time_limit=limit, 
        
                           ) 
        
                       ).rows[0][0] 
        
                       counts[table] = table_count 
        
                   # In some cases I saw "SQL Logic Error" here in addition to 
        
                   # QueryInterrupted - so we catch that too: 
        
                   except (QueryInterrupted, sqlite3.OperationalError, sqlite3.DatabaseError): 
        
                       counts[table] = None 
        
               if not self.is_mutable: 
        
                   self._cached_table_counts = counts 
        
               return counts

	async def table_counts(self, limit=10):
	if not self.is_mutable and self.cached_table_counts is not None:
	return self.cached_table_counts
	# Try to get counts for each table, $limit timeout for each count
	counts = {}
	for table in await self.table_names():
	try:
	table_count = (
	await self.execute(
	f"select count(*) from [{table}]",
	custom_time_limit=limit,
	)
	).rows[0][0]
	counts[table] = table_count
	# In some cases I saw "SQL Logic Error" here in addition to
	# QueryInterrupted - so we catch that too:
	except (QueryInterrupted, sqlite3.OperationalError, sqlite3.DatabaseError):
	counts[table] = None
	if not self.is_mutable:
	self._cached_table_counts = counts
	return counts

Uh oh!

Speed up table counts when displaying index and database pages #2398

Description

Metadata

Metadata

Assignees

Labels

Projects

Milestone

Relationships

Development

Issue actions