Skip to content

Run delete_everything inside a transaction #2273

New issue
New issue
Closed
Closed
Run delete_everything inside a transaction#2273
Labels
bug
Milestone
Datasette 1.0a9
@simonw

Description

@simonw
simonw
opened on Feb 16, 2024

This should use an explicit transaction to avoid "database locked" errors:

datasette/datasette/utils/internal_db.py

Lines 68 to 85 in b89cac3

async def populate_schema_tables(internal_db, db):
database_name = db.name
def delete_everything(conn):
conn.execute(
"DELETE FROM catalog_tables WHERE database_name = ?", [database_name]
)
conn.execute(
"DELETE FROM catalog_columns WHERE database_name = ?", [database_name]
)
conn.execute(
"DELETE FROM catalog_foreign_keys WHERE database_name = ?", [database_name]
)
conn.execute(
"DELETE FROM catalog_indexes WHERE database_name = ?", [database_name]
)
await internal_db.execute_write_fn(delete_everything)

Metadata

Metadata

Assignees

No one assigned

    Labels

    bug

    Projects

    No projects

    Milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions