From a code point of view, the current mechanism for _group_count makes the TableView even more complicated:

Lines 644 to 653 in 446d47f

    
           # _group_count=col1&_group_count=col2 
        
           group_count = special_args_lists.get('_group_count') or [] 
        
           if group_count: 
        
               count_sql = None 
        
               sql = 'select {group_cols}, count(*) as "count" from {table_name} {where} group by {group_cols} order by "count" desc limit 100'.format( 
        
                   group_cols=', '.join('"{}"'.format(group_count_col) for group_count_col in group_count), 
        
                   table_name=escape_sqlite(table), 
        
                   where=where_clause, 
        
               ) 
        
               is_view = True

Instead, I think if _group_count is detected we should generate the SQL and then defer to self.custom_sql, like we do for canned queries:

datasette/datasette/app.py

Lines 539 to 541 in 446d47f

    
           canned_query = self.ds.get_canned_query(name, table) 
        
           if canned_query is not None: 
        
               return await self.custom_sql(request, name, hash, canned_query['sql'], editable=False, canned_query=table)

	# _group_count=col1&_group_count=col2
	group_count = special_args_lists.get('_group_count') or []
	if group_count:
	count_sql = None
	sql = 'select {group_cols}, count(*) as "count" from {table_name} {where} group by {group_cols} order by "count" desc limit 100'.format(
	group_cols=', '.join('"{}"'.format(group_count_col) for group_count_col in group_count),
	table_name=escape_sqlite(table),
	where=where_clause,
	)
	is_view = True

	canned_query = self.ds.get_canned_query(name, table)
	if canned_query is not None:
	return await self.custom_sql(request, name, hash, canned_query['sql'], editable=False, canned_query=table)

Uh oh!

_group_count= feature improvements #150

Description

Metadata

Metadata

Assignees

Labels

Projects

Milestone

Relationships

Development

Issue actions