Skip to content

Implemented branch coverage tool for AuthorListParser::getToken#7

Merged
yiiju merged 5 commits into
masterfrom
getToken
Feb 18, 2020
Merged

Implemented branch coverage tool for AuthorListParser::getToken#7
yiiju merged 5 commits into
masterfrom
getToken

Conversation

@yiiju

@yiiju yiiju commented Feb 16, 2020

Copy link
Copy Markdown
Collaborator

Added

  • Branch coverage tool for AuthorListParser::getToken.

@yiiju yiiju changed the title Get token Implemented branch coverage tool for AuthorListParser::getToken Feb 16, 2020
Comment thread src/main/java/org/jabref/model/entry/AuthorListParser.java
@SoFoDa SoFoDa self-requested a review February 17, 2020 15:28

@SoFoDa SoFoDa left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work 👍

@christinerosquist christinerosquist left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 🔥

@simonsirak simonsirak left a comment

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, nice job! I had a similar comment as David but otherwise it looks great!

Comment thread src/main/java/org/jabref/model/entry/AuthorListParser.java
@yiiju yiiju merged commit 8a14a90 into master Feb 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants