Added branch coverage tool and unit tests for Authors::handleArgument#3
Merged
Conversation
simonsirak
approved these changes
Feb 15, 2020
simonsirak
left a comment
Owner
There was a problem hiding this comment.
Looks good! 👍Had a couple of questions but nothing crucial. I pushed some modifications I had made to our tool, since it had some bugs. It should still work fine though, hopefully ^^
christinerosquist
approved these changes
Feb 16, 2020
christinerosquist
left a comment
Collaborator
There was a problem hiding this comment.
Looks good! Nice job, I approve 👍
SoFoDa
approved these changes
Feb 17, 2020
simonsirak
approved these changes
Feb 18, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added
Authors::handleArgument.Authors::handleArgumentfunction into a new file calledAuthorsRefactorand unit tests file calledAuthorsRefactorTestto reduce cyclomatic complexity from 36 to 7.