Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #138 issue with tape decoding where, in ld-decode-tools, ld-analyse contained a hack to preview a decoding path that ld-chroma-decoder did not support. Decode-Orc now implements this by improving the actual decoder (without requiring an ffmpeg processing loop) - and the orc-gui preview path is exactly the same as the decoder output path. So, it's not the same as the previous tool chain, but the results should be.
There was also a minor issue with parameters - the ffmpeg parameter for NTSC phase compensation was on by default, but off by default when the parameter editing window was open.
I added a bunch of unit testing to ffmpeg video sink, raw video sink and the underlying chroma decoder paths.
Issue #143 was around better support for agentic AI - now the project includes clear instructions for the agent to add additional colour to the existing documentation. I also updated the existing documentation to make everything clear.
Type of change
Validation
GUI testing and unit testing
Checklist
Related issue
Closes #138 and #143