Skip to content

Updating workflows/sars-cov-2-variant-calling/sars-cov-2-pe-illumina-artic-variant-calling from 0.4.2 to 0.4.3#37

Closed
planemo-autoupdate wants to merge 1 commit intosimonbray:mainfrom
planemo-autoupdate:workflows/sars-cov-2-variant-calling/sars-cov-2-pe-illumina-artic-variant-calling
Closed

Updating workflows/sars-cov-2-variant-calling/sars-cov-2-pe-illumina-artic-variant-calling from 0.4.2 to 0.4.3#37
planemo-autoupdate wants to merge 1 commit intosimonbray:mainfrom
planemo-autoupdate:workflows/sars-cov-2-variant-calling/sars-cov-2-pe-illumina-artic-variant-calling

Conversation

@planemo-autoupdate
Copy link

Hello! This is an automated update of the following workflow: workflows/sars-cov-2-variant-calling/sars-cov-2-pe-illumina-artic-variant-calling. I created this PR because I think one or more of the component tools are out of date, i.e. there is a newer version available on the ToolShed.

By comparing with the latest versions available on the ToolShed, it seems the following tools are outdated:

  • toolshed.g2.bx.psu.edu/repos/devteam/bwa/bwa_mem/0.7.17.1 should be updated to toolshed.g2.bx.psu.edu/repos/devteam/bwa/bwa_mem/0.7.17.2
  • toolshed.g2.bx.psu.edu/repos/iuc/samtools_view/samtools_view/1.9+galaxy2 should be updated to toolshed.g2.bx.psu.edu/repos/iuc/samtools_view/samtools_view/1.13
  • toolshed.g2.bx.psu.edu/repos/devteam/samtools_stats/samtools_stats/2.0.2+galaxy2 should be updated to toolshed.g2.bx.psu.edu/repos/devteam/samtools_stats/samtools_stats/2.0.3
  • toolshed.g2.bx.psu.edu/repos/iuc/ivar_trim/ivar_trim/1.3.1+galaxy0 should be updated to toolshed.g2.bx.psu.edu/repos/iuc/ivar_trim/ivar_trim/1.3.1+galaxy2
  • toolshed.g2.bx.psu.edu/repos/iuc/lofreq_call/lofreq_call/2.1.5+galaxy0 should be updated to toolshed.g2.bx.psu.edu/repos/iuc/lofreq_call/lofreq_call/2.1.5+galaxy1
  • toolshed.g2.bx.psu.edu/repos/iuc/ivar_removereads/ivar_removereads/1.3.1+galaxy0 should be updated to toolshed.g2.bx.psu.edu/repos/iuc/ivar_removereads/ivar_removereads/1.3.1+galaxy2
  • toolshed.g2.bx.psu.edu/repos/iuc/multiqc/multiqc/1.9+galaxy1 should be updated to toolshed.g2.bx.psu.edu/repos/iuc/multiqc/multiqc/1.11+galaxy0

The workflow release number has been updated from 0.4.2 to 0.4.3.

"amplicon_info": {
"id": 3,
"output_name": "output"
},
Copy link

@wm75 wm75 Jan 21, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm, this changes WF behavior. ivar_removereads at the suggested wrapper version can compute amplicon info on the fly if the structure of its "input_bed" input allows. However, it also still accepts an amplicon_info dataset conditionally, and for backwards-compatibility that's the desired way to go (compare also the Changelog for galaxyproject#82).

So somehow potentially disrupting changes like this one (where an input_connection gets dropped) should be flagged by the bot. Not exactly sure how at the moment.

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It should be possible to flag the changes, I'll have a look at it.

I hope this can be considered as a nice future enhancement and not something that needs to be implemented straightaway though.

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I hope this can be considered as a nice future enhancement and not something that needs to be implemented straightaway though.

Absolutely, the suggestions are mostly really useful already!

@simonbray simonbray closed this Jan 24, 2022
@planemo-autoupdate planemo-autoupdate deleted the workflows/sars-cov-2-variant-calling/sars-cov-2-pe-illumina-artic-variant-calling branch January 24, 2022 18:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants