internal/integrations/gemini/retry.go (1)

60-103: Seed math/rand so jitter isn’t deterministic across processes.

Without seeding, jitter uses a fixed sequence, which can reduce thundering‑herd protection across instances.

🛠️ Suggested fix

 import (
 	"context"
 	"fmt"
 	"math"
 	"math/rand"
 	"strings"
 	"time"
 )
+
+func init() {
+	rand.Seed(time.Now().UnixNano())
+}

internal/integrations/gemini/retry.go (1)

63-91: Use a per-call RNG to avoid relying on global state for jitter randomness.

Currently, rand.Float64() uses Go's global RNG. While modern Go versions (1.20+) automatically seed it, a per-call RNG is clearer and doesn't depend on implicit seeding behavior.

♻️ Suggested refactor

 func withRetry[T any](ctx context.Context, cfg RetryConfig, operation string, fn func() (T, error)) (T, error) {
 	var zero T
+	rng := rand.New(rand.NewSource(time.Now().UnixNano()))
 
 	for attempt := 0; attempt <= cfg.MaxRetries; attempt++ {
@@
 		// Add jitter to prevent thundering herd
 		if cfg.JitterRatio > 0 {
-			jitter := time.Duration(rand.Float64() * cfg.JitterRatio * float64(delay))
+			jitter := time.Duration(rng.Float64() * cfg.JitterRatio * float64(delay))
 			delay += jitter
 		}

internal/integrations/gemini/llm.go (1)

127-152: Consider making retry configuration injectable for testability.

The helper hardcodes DefaultRetryConfig(), which works for production but makes unit testing difficult (tests must wait through real delays or rely on stubbing the time package). Consider accepting RetryConfig as a parameter or storing it on LLMClient for flexibility.

// Option 1: Add to LLMClient
type LLMClient struct {
    client      *genai.Client
    model       string
    retryConfig RetryConfig // Add field
}

// Option 2: Accept as parameter
func (l *LLMClient) generateWithRetry(ctx context.Context, cfg RetryConfig, model *genai.GenerativeModel, prompt string, operation string) (string, error)

The whitespace guard on lines 147-149 correctly addresses the earlier review feedback.

internal/integrations/gemini/retry.go (1)

35-59: Consider using typed error checking instead of string matching for more robust retry logic.

String-based matching for "429", "Internal", "Unavailable" is fragile and could lead to false positives—for example, "Internal" appears in many non-5xx error contexts. The project already has google.golang.org/api v0.186.0 and github.com/googleapis/gax-go/v2 in dependencies, which expose *googleapi.Error (with Code field) and *apierror.APIError (with HTTPCode() method). Use errors.As() to type-assert these errors instead:

var gerr *googleapi.Error
if errors.As(err, &gerr) {
  return gerr.Code == 429 || (gerr.Code >= 500 && gerr.Code < 600)
}

This approach is more maintainable and eliminates substring-matching ambiguity.