Walkthrough

Adds a Simili web UI and CLI batch command, extracts pipeline execution into a reusable API, enriches similarity/duplicate detection with full-body context and reasoning, and expands embedding configuration keys. Includes frontend assets, backend server, batch processing, tests, and documentation.

Changes

Sequence Diagram

sequenceDiagram
    participant Browser
    participant WebServer as Web Server
    participant Config as Config Loader
    participant Deps as Dependencies
    participant Pipeline as Pipeline Executor
    participant Qdrant as Qdrant Vector DB
    participant Gemini as Gemini LLM
    participant Response as Response Builder

    Browser->>WebServer: POST /api/analyze (IssueRequest)
    activate WebServer

    WebServer->>Config: Load .simili.yaml and env overrides
    Config-->>WebServer: Config
    WebServer->>Deps: Initialize embedder, vector store, LLM (dry-run)
    Deps-->>WebServer: Dependencies ready

    WebServer->>Pipeline: ExecutePipeline(issue, cfg, deps, steps..., silent=true)
    activate Pipeline

    Pipeline->>Qdrant: Search similar issues
    Qdrant-->>Pipeline: Similar issues + metadata
    Pipeline->>Gemini: Duplicate analysis (includes bodies)
    Gemini-->>Pipeline: DuplicateResult + reasoning

    Pipeline-->>WebServer: Pipeline.Result
    deactivate Pipeline

    WebServer->>Response: Build AnalysisResponse JSON
    Response-->>WebServer: Response
    WebServer-->>Browser: 200 OK + AnalysisResponse
    deactivate WebServer

Estimated code review effort

🎯 4 (Complex) | ⏱️ ~60 minutes

Possibly related issues

• simili-bot#34: Implements the requested simili batch CLI and extracts pipeline execution into ExecutePipeline, matching the issue's objectives.

Poem

🐰 I hopped through code and stitched a flow,

Bodies and reasons now ready to show,
Batches march onward, the web listens too,
Qdrant hums softly and Gemini knew,
Pipelines sing — hooray! — a rabbit-made view.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

• 📝 Generate docstrings

cmd/simili-web/main.go (5)

95-96: Ignored error from fs.Sub could mask embed issues.

The error from fs.Sub is discarded with a blank identifier. If the "static" subdirectory doesn't exist in the embedded filesystem, the server will silently fail to serve static files.

Proposed fix

-	staticFS, _ := fs.Sub(staticFiles, "static")
+	staticFS, err := fs.Sub(staticFiles, "static")
+	if err != nil {
+		log.Fatalf("Failed to access embedded static files: %v", err)
+	}
 	http.Handle("/", http.FileServer(http.FS(staticFS)))

---

267-271: Use errors.Is() for sentinel error comparison.

Direct comparison with != may fail if the error is wrapped. Use errors.Is() for reliable sentinel error checks.

Proposed fix

+import "errors"
+
 	if err := builtPipeline.Run(pCtx); err != nil {
-		if err != pipeline.ErrSkipPipeline {
+		if !errors.Is(err, pipeline.ErrSkipPipeline) {
 			return nil, err
 		}
 	}

---

183-192: Missing HTTP status code for JSON decode errors.

When JSON decoding fails, the response is written with status 200 (default) but contains an error payload. Consider setting an appropriate 4xx status code for client errors.

Proposed fix

 	var req IssueRequest
 	if err := json.NewDecoder(r.Body).Decode(&req); err != nil {
+		w.WriteHeader(http.StatusBadRequest)
 		if encErr := json.NewEncoder(w).Encode(AnalysisResponse{
 			Success: false,
 			Error:   "Invalid JSON: " + err.Error(),

---

194-203: Missing HTTP status code for validation errors.

Similar to the JSON decode error, validation failures return status 200 with an error payload. Setting a 4xx status improves API semantics.

Proposed fix

 	// Validate required fields
 	if req.Title == "" {
+		w.WriteHeader(http.StatusBadRequest)
 		if err := json.NewEncoder(w).Encode(AnalysisResponse{
 			Success: false,
 			Error:   "Title is required",

---

228-236: Pipeline errors should return 5xx status.

Internal pipeline errors currently return status 200 with an error payload. A 500 status would be more appropriate for server-side failures.

Proposed fix

 	// Run pipeline
 	result, err := runPipeline(issue)
 	if err != nil {
+		w.WriteHeader(http.StatusInternalServerError)
 		if encErr := json.NewEncoder(w).Encode(AnalysisResponse{
 			Success: false,
 			Error:   "Pipeline error: " + err.Error(),

cmd/simili-web/static/app.js (1)

111-113: Potential NaN display if Similarity is missing.

If an issue object lacks the Similarity field (undefined), multiplying by 100 yields NaN, displaying "NaN%" to users. Consider defensive handling.

Proposed fix

         issues.forEach(issue => {
-            const score = (issue.Similarity * 100).toFixed(1);
+            const score = ((issue.Similarity || 0) * 100).toFixed(1);
             const stateClass = issue.State === 'open' ? 'status-open' : 'status-closed';

cmd/simili/commands/batch.go (2)

340-350: Redundant nil check on geminiKey.

The check if geminiKey != "" on line 341 is always true because lines 288-290 already return an error if geminiKey is empty. This conditional can be removed.

Proposed fix

 	// Initialize LLM Client
-	if geminiKey != "" {
-		llm, err := gemini.NewLLMClient(geminiKey)
-		if err != nil {
-			return nil, fmt.Errorf("failed to initialize Gemini LLM client: %w", err)
-		}
-		deps.LLMClient = llm
-		if verbose {
-			fmt.Println("✓ Initialized Gemini LLM client")
-		}
+	llm, err := gemini.NewLLMClient(geminiKey)
+	if err != nil {
+		return nil, fmt.Errorf("failed to initialize Gemini LLM client: %w", err)
+	}
+	deps.LLMClient = llm
+	if verbose {
+		fmt.Println("✓ Initialized Gemini LLM client")
 	}

---

101-103: Consider logging instead of printing warning for flag marking failure.

The MarkFlagRequired error is printed but execution continues. In practice, this error should never occur with valid flag names, but logging rather than printing would be more consistent.

Proposed fix

+import "log"
+
 	if err := batchCmd.MarkFlagRequired("file"); err != nil {
-		fmt.Printf("Warning: Failed to mark file flag as required: %v\n", err)
+		log.Printf("Warning: Failed to mark file flag as required: %v", err)
 	}