feat: Implement Transfer Rules Engine for Cross-Repository Issue Routing by Kavirubc · Pull Request #22 · similigh/simili-bot

Kavirubc · 2026-02-04T05:44:14Z

Summary

Implements the Transfer Rules Engine for cross-repository issue routing as specified in issue #15. This enables automated issue transfers based on configurable rules matching labels, title/body content, and authors.

Changes

Core Transfer Logic

New Package: internal/transfer/ with rule matching engine
- RuleMatcher evaluates rules by priority (descending order)
- Case-insensitive matching for all conditions
- Support for AND (labels) and OR (labels_any, title_contains, body_contains, author) logic
- 12 comprehensive unit tests covering all scenarios

Configuration

Added TransferRule and TransferConfig types to internal/core/config/config.go
Supports rule conditions: labels (ALL), labels_any (ANY), title_contains, body_contains, author
Rules can be enabled/disabled and sorted by priority

Pipeline Integration

Moved transfer_check step before similarity_search in pipeline (prevents duplicate detection for transfers)
transfer_check sets skip_duplicate_detection metadata when transfer is detected
Updated similarity_search to respect skip flag

GitHub GraphQL Integration

New: internal/integrations/github/graphql.go - GraphQL client implementation
Implements transferIssue mutation with proper node ID resolution
Updated Client.TransferIssue() to use GraphQL API (returns new issue URL)
Requires authenticated GraphQL client (initialized in auth.go)

Action Executor

Updated to handle new TransferIssue signature returning (string, error)
Logs new issue URL after successful transfer
Sets Result.Transferred = true on success

Architecture

Config (YAML)         transfer/RuleMatcher       pipeline.Context
transfer_rules  -->   Match(issue)          -->  TransferTarget, Metadata
                           |
                           v
                   ActionExecutor --> GitHub GraphQL TransferIssue()

Configuration Example

transfer:
  enabled: true
  rules:
    - name: "critical-bugs-to-core"
      priority: 100
      target: "org/core-repo"
      labels: ["bug", "critical"]
      
    - name: "feature-requests-to-roadmap"
      priority: 50
      target: "org/roadmap"
      labels_any: ["feature", "enhancement"]
      title_contains: ["feature request", "add support"]

Testing

✅ All transfer package tests pass (12/12)
✅ All integration tests pass
✅ Build successful with no errors
✅ Updated GitHub client tests for new signature

Notes

Transfer requires admin/write access to both source and target repositories
Validation ensures target repo format is "owner/repo"
GraphQL client only initialized when authentication token is provided

Closes #15

…atching and GraphQL API integration.

… GraphQL client validation, which is then used by the action executor.

Copilot

Pull request overview

This pull request implements a comprehensive Transfer Rules Engine for automated cross-repository issue routing, addressing issue #15. The implementation adds rule-based matching with configurable conditions (labels, content patterns, authors), GraphQL-based issue transfer functionality, and pipeline integration to prevent duplicate detection for transferred issues.

Changes:

New internal/transfer/ package with rule matching engine supporting priority-based evaluation and case-insensitive matching with comprehensive test coverage (12 tests)
GraphQL client implementation for GitHub's transferIssue mutation with proper node ID resolution
Pipeline reordering to execute transfer checks before similarity search, with metadata-based skip logic
Configuration types for transfer rules with support for AND/OR logic across multiple condition types

Reviewed changes

Copilot reviewed 14 out of 14 changed files in this pull request and generated 5 comments.

Show a summary per file

File	Description
internal/transfer/types.go	Defines data structures for issue input and match results
internal/transfer/matcher.go	Implements rule matching engine with priority-based evaluation and case-insensitive matching logic
internal/transfer/matcher_test.go	Comprehensive test coverage for all matching scenarios (12 test cases)
internal/steps/transfer_check.go	Pipeline step that evaluates transfer rules and sets transfer target with skip metadata
internal/steps/similarity.go	Updated to skip duplicate detection when transfer is detected
internal/steps/action_executor.go	Updated to handle new TransferIssue signature returning URL and set Transferred flag
internal/integrations/github/graphql.go	New GraphQL client with transferIssue mutation and node ID resolution methods
internal/integrations/github/client.go	TransferIssue implementation using GraphQL API with validation and error handling
internal/integrations/github/auth.go	GraphQL client initialization for authenticated operations
internal/integrations/github/client_test.go	Updated tests for new TransferIssue signature
internal/core/pipeline/registry.go	Reordered pipeline to execute transfer_check before similarity_search
internal/core/config/config.go	Added TransferRule and TransferConfig types with merge logic
.claude/sessions/2026-02-04-0000.md	Development session tracking metadata
.claude/sessions/.current-session	Current session reference

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot · 2026-02-04T06:24:34Z

 	// Validate input format
 	parts := strings.Split(targetRepo, "/")
 	if len(parts) != 2 {
-		return fmt.Errorf("invalid targetRepo format: expected 'owner/repo', got '%s'", targetRepo)
+		return "", fmt.Errorf("invalid targetRepo format: expected 'owner/repo', got '%s'", targetRepo)


The validation doesn't trim whitespace from the target repository string before parsing. A target like "owner/repo " (with trailing space) would pass validation but might cause issues with the GraphQL API. Consider trimming whitespace from the targetRepo parameter before validation and parsing to handle user input more robustly.

Copilot · 2026-02-04T06:24:35Z

+	if resp.StatusCode != http.StatusOK {
+		return nil, fmt.Errorf("GraphQL request failed with status %d: %s", resp.StatusCode, string(respBody))


The error message includes the full response body which could potentially leak sensitive information in logs. Consider truncating the response body or only including a sanitized portion of it in the error message to avoid exposing sensitive data that might be in error responses.

Copilot · 2026-02-04T06:24:35Z

+	if err := json.Unmarshal(data, &result); err != nil {
+		return "", fmt.Errorf("failed to parse transfer result: %w", err)
+	}
+


The function returns the URL without validating that the transfer was successful. Consider adding a check to ensure the returned URL is not empty, similar to the validation done in GetIssueNodeID and GetRepositoryNodeID. An empty URL could indicate a failed transfer that wasn't caught by error handling.

Suggested change

if result.TransferIssue.Issue.URL == "" {

return "", fmt.Errorf("issue transfer failed: empty URL returned")

}

Copilot · 2026-02-04T06:24:35Z

+	// Transfer: child overrides if enabled or has rules
+	if child.Transfer.Enabled || len(child.Transfer.Rules) > 0 {
+		result.Transfer = child.Transfer


The merge logic for Transfer config only overrides if child.Transfer.Enabled is true or has rules. This means a child config cannot explicitly disable transfer if the parent has it enabled. Consider always merging the Transfer config if any field is set in the child, or add explicit handling for the case where a child wants to disable an enabled parent transfer configuration. For consistency with other boolean fields like CrossRepoSearch (line 232), consider whether Transfer.Enabled should be merged regardless of its value.

Suggested change

// Transfer: child overrides if enabled or has rules

if child.Transfer.Enabled || len(child.Transfer.Rules) > 0 {

result.Transfer = child.Transfer

// Transfer.Enabled: always take the child value so it can override parent true -> false and vice versa

result.Transfer.Enabled = child.Transfer.Enabled

// Transfer.Rules: child overrides rules if non-empty; otherwise inherit from parent

if len(child.Transfer.Rules) > 0 {

result.Transfer.Rules = child.Transfer.Rules

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

- Add whitespace trimming for targetRepo input validation - Truncate error response bodies to prevent sensitive data leaks - Add empty URL validation after transfer completion - Fix Transfer config merge logic to allow child to disable parent

Kavirubc added 3 commits February 4, 2026 11:12

feat: Create new development session and set as current.

d9c16d0

feat: Implement GitHub issue transfer functionality with rule-based m…

5193e23

…atching and GraphQL API integration.

feat: Enhance TransferIssue to return the new issue URL and improve…

dc66e22

… GraphQL client validation, which is then used by the action executor.

Kavirubc changed the title ~~Implement Cross Repo Transfer~~ feat: Implement Transfer Rules Engine for Cross-Repository Issue Routing Feb 4, 2026

Kavirubc marked this pull request as ready for review February 4, 2026 06:19

Kavirubc requested a review from Copilot February 4, 2026 06:19

Copilot started reviewing on behalf of Kavirubc February 4, 2026 06:19 View session

Copilot AI reviewed Feb 4, 2026

View reviewed changes

Update internal/transfer/matcher.go

2a312c7

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

Kavirubc mentioned this pull request Feb 4, 2026

[v0.2.0] Hybrid Transfer Routing: Combine Rule-Based + VDB Semantic Matching #23

Closed

12 tasks

fix: address code review feedback

269757b

- Add whitespace trimming for targetRepo input validation - Truncate error response bodies to prevent sensitive data leaks - Add empty URL validation after transfer completion - Fix Transfer config merge logic to allow child to disable parent

Kavirubc merged commit 53abf8b into main Feb 4, 2026
3 checks passed

Kavirubc deleted the feature/repo-tranfer-010 branch February 4, 2026 06:31

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: Implement Transfer Rules Engine for Cross-Repository Issue Routing#22

feat: Implement Transfer Rules Engine for Cross-Repository Issue Routing#22
Kavirubc merged 5 commits intomainfrom
feature/repo-tranfer-010

Kavirubc commented Feb 4, 2026 •

edited

Loading

Uh oh!

Copilot AI left a comment

Uh oh!

Copilot AI Feb 4, 2026

Uh oh!

Copilot AI Feb 4, 2026

Uh oh!

Copilot AI Feb 4, 2026

Uh oh!

Copilot AI Feb 4, 2026

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

		if resp.StatusCode != http.StatusOK {
		return nil, fmt.Errorf("GraphQL request failed with status %d: %s", resp.StatusCode, string(respBody))

+	if result.TransferIssue.Issue.URL == "" {
+		return "", fmt.Errorf("issue transfer failed: empty URL returned")
+	}

-	// Transfer: child overrides if enabled or has rules
-	if child.Transfer.Enabled || len(child.Transfer.Rules) > 0 {
-		result.Transfer = child.Transfer
+	// Transfer.Enabled: always take the child value so it can override parent true -> false and vice versa
+	result.Transfer.Enabled = child.Transfer.Enabled
+	// Transfer.Rules: child overrides rules if non-empty; otherwise inherit from parent
+	if len(child.Transfer.Rules) > 0 {
+		result.Transfer.Rules = child.Transfer.Rules

Conversation

Kavirubc commented Feb 4, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Changes

Core Transfer Logic

Configuration

Pipeline Integration

GitHub GraphQL Integration

Action Executor

Architecture

Configuration Example

Testing

Notes

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Copilot AI Feb 4, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Feb 4, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Feb 4, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Feb 4, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Kavirubc commented Feb 4, 2026 •

edited

Loading