Skip to content

polish the functions in encoding_types.h #894

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
pauldreik merged 2 commits into from
Jan 4, 2026
Merged

polish the functions in encoding_types.h #894

pauldreik merged 2 commits into from
Jan 4, 2026
+14 −15

Conversation

@pauldreik
Copy link
Collaborator

@pauldreik pauldreik commented Jan 4, 2026 •
edited
Loading

  1. adds warn_unused
  2. force inline of the match_system() function
  3. get rid of macros inside the match_system() function

@pauldreik
remove macros from simdutf::match_system()
79c2a18 
also, it is now definitely inlined which has the side effect of making
the debug build about 200 K smaller (measured as the size of the build
folder)
@pauldreik
add simdutf_warn_unused to functions in encoding_types.h
8299cb5
@pauldreik pauldreik merged commit 98d482f into master Jan 4, 2026
105 checks passed
@pauldreik pauldreik deleted the extra_attributes branch January 4, 2026 19:24
@BrewTestBot BrewTestBot mentioned this pull request Jan 13, 2026
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lemire lemire lemire approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@pauldreik @lemire