-
Notifications
You must be signed in to change notification settings - Fork 115
Fix typos #888
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix typos #888
Conversation
| } | ||
| #endif | ||
| #define SIMDUTF_GET_CURRENT_IMPLEMENTION | ||
| #define SIMDUTF_GET_CURRENT_IMPLEMENTATION |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not being used anywhere?
$ rg SIMDUTF_GET_CURRENT_IMPLEMENTION
src/implementation.cpp
1425:#define SIMDUTF_GET_CURRENT_IMPLEMENTION
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
seems like it can be removed entirely!
|
thanks! |
|
@kianmeng Any chance you might omit If it is inconvenient, we may still merge this PR... |
|
@lemire @pauldreik |
|
looks good! |
|
@pauldreik Although we can merge and then lint. It is not a very challenging problem. :-) |
|
@pauldreik Clang patch applied, ddd1a28 |
|
Thanks @kianmeng ! |
|
🥳 🥳 🥳 🥳 🥳 |
Short title (summary): Fix typos
Description
Found via
codespell -S ./build,./benchmarks/competition -L vie,persan,fo,ans,larg,indx,shft,carryinandtypos --hidden --format briefType of change
How to verify / test
Please read before contributing:
If you can, we recommend running our tests with the sanitizers turned on.
For non-Visual Studio users, it is as easy as doing:
Our CI checks, among other things, for trailing whitespace.
Checklist before submitting
Final notes
Thanks for the contribution!