Skip to content

Conversation

@shikharish
Copy link
Contributor

Related to #845

@shikharish
Copy link
Contributor Author

Tested on g++-15 on MacOS(M1). I believe std::text_encoding is only available in libstdc++ for now. clang-21 doesn't seem to support it.

@shikharish
Copy link
Contributor Author

@lemire Request for review.

Copy link
Collaborator

@pauldreik pauldreik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice job!

@pauldreik
Copy link
Collaborator

I added a PR with a C++26 build: #883

@lemire
Copy link
Member

lemire commented Dec 29, 2025

No need to worry about the clang format error/warning.

@shikharish
Copy link
Contributor Author

Made the requested changes.

Copy link
Collaborator

@pauldreik pauldreik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nearly there!

@pauldreik
Copy link
Collaborator

let's merge this when the CI is green

@pauldreik pauldreik merged commit ead4d9c into simdutf:master Dec 30, 2025
62 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants