-
Notifications
You must be signed in to change notification settings - Fork 116
interop with std::text_encoding #881
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Tested on g++-15 on MacOS(M1). I believe |
|
@lemire Request for review. |
92ef0e9 to
218d9d6
Compare
pauldreik
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice job!
|
I added a PR with a C++26 build: #883 |
|
No need to worry about the clang format error/warning. |
218d9d6 to
b7a27ad
Compare
|
Made the requested changes. |
pauldreik
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nearly there!
b7a27ad to
b0f9129
Compare
|
let's merge this when the CI is green |
Related to #845